[PATCH] D98103: [NPM] Do not run function simplification pipeline unnecessarily

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/CGSCCPassManager.cpp:594
+      CurrentC = &updateCGAndAnalysisManagerForPass(CG, *CurrentC, *N, AM, UR,
+                                                    FAM, true, false);
       assert(CG.lookupSCC(*N) == CurrentC &&
----------------
aeubanks wrote:
> nit: `/*FunctionPass*/ true, /*InvalidateSA*/ false`
this can go back to the original code


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1033
+    FSP.addPass(RequireAnalysisPass<FunctionStatusAnalysis, Function>());
+  MainCGPipeline.addPass(createCGSCCToFunctionPassAdaptor(std::move(FSP)));
 
----------------
do we need to add a pass to invalidate FunctionStatusAnalysis after the inliner pipeline so that CGSCC pipelines after the inliner pipeline aren't skipped?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98103/new/

https://reviews.llvm.org/D98103