[PATCH] D101510: Do not merge memcpy if the first source is a parameter of coroutine function
Xun Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 4 12:50:49 PDT 2021
lxfind added a comment.
In D101510#2736924 <https://reviews.llvm.org/D101510#2736924>, @rnk wrote:
> Since we are already in the space of finding workarounds, when is the memcpy of the byval parameter introduced? Is it compiler generated? If so, could it be marked volatile there? This would limit the coroutines-specific workaround to coroutine code, which move the tech debt burden from generic LLVM code to coroutines code. That would work.
Thanks for the suggestions. We may have a way to fix this within coroutine passes (by explicitly looking for byval params and copy them).
@ChuanqiXu is looking into it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101510/new/
https://reviews.llvm.org/D101510
More information about the llvm-commits
mailing list