[PATCH] D101833: [AArch64][SVE] Fix missed immediate selection due to mishandling of signedness

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 4 11:19:38 PDT 2021


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:3128
+                  ((int32_t)ImmVal >= -32768) &&
+                  ((int32_t)ImmVal <= 32512)) {
+        Shift = CurDAG->getTargetConstant(8, DL, MVT::i32);
----------------
Does checking `((int32_t)ImmVal >= -32768) && ((int32_t)ImmVal <= 32512))` actually do anything?  All 16-bit immediates should be in that range.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101833/new/

https://reviews.llvm.org/D101833



More information about the llvm-commits mailing list