[PATCH] D101815: [SampleFDO] Fix a bug when appending function symbol into the Callees set of Root node in ProfiledCallGraph.

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 4 10:06:37 PDT 2021


This revision was automatically updated to reflect the committed changes.
Closed by commit rG82956de05f9d: [SampleFDO] Fix a bug when appending function symbol into the Callees set of (authored by wmi).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101815/new/

https://reviews.llvm.org/D101815

Files:
  llvm/include/llvm/Transforms/IPO/ProfiledCallGraph.h


Index: llvm/include/llvm/Transforms/IPO/ProfiledCallGraph.h
===================================================================
--- llvm/include/llvm/Transforms/IPO/ProfiledCallGraph.h
+++ llvm/include/llvm/Transforms/IPO/ProfiledCallGraph.h
@@ -87,8 +87,8 @@
     if (!ProfiledFunctions.count(Name)) {
       // Link to synthetic root to make sure every node is reachable
       // from root. This does not affect SCC order.
-      Root.Callees.insert(&ProfiledFunctions[Name]);
       ProfiledFunctions[Name] = ProfiledCallGraphNode(Name);
+      Root.Callees.insert(&ProfiledFunctions[Name]);
     }
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101815.342786.patch
Type: text/x-patch
Size: 610 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210504/e973c912/attachment.bin>


More information about the llvm-commits mailing list