[PATCH] D101789: [test-suite] SPEC2017 CPU wrf floating point tests.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: External/SPEC/CFP2017rate/521.wrf_r/CMakeLists.txt:13
+
+set(WRF_SPECPP WRF_SPECPP_${BENCHMARK_SUITE_TYPE})
+
----------------
This is odd. Why not using `WRF_SPECPP_${BENCHMARK_SUITE_TYPE}` directly?

It seems to be uses as library name. Capitalizaton is odd for a library.


================
Comment at: External/SPEC/CFP2017rate/521.wrf_r/CMakeLists.txt:23-39
+  # build and run the wrf test validator, then checks several binaries
+  # files, e.g. wrfout_d01_2000-01-24_14_00_00 to make sure the test pass.
+  #
+
+  # the validator for the speed and rate test are the same so we hard
+  # code in the location of the binary in the rate directory.
+  #
----------------
Could you move the macro documentation before the macro?


================
Comment at: External/SPEC/CFP2017rate/521.wrf_r/CMakeLists.txt:153-154
+        period.c
+	read_grib.c
+	reg_parse.c
+        rsl_bcast.c
----------------
[nit] indention


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101789/new/

https://reviews.llvm.org/D101789