[PATCH] D101234: GlobalISel: Use DAG call lowering infrastructure in a more compatible way

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h:222
 
-    virtual bool assignArg(unsigned ValNo, MVT ValVT, MVT LocVT,
+    /// Wrap call to (typically tablegenerated CCAssignFn. This may be
+    /// overridden to track additional state information as arguments are
----------------
Missing )


================
Comment at: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp:310
+                              ArrayRef<Register> Regs, LLT LLTy, LLT PartLLT,
+                              /*LLT LocTy, */ const ISD::ArgFlagsTy Flags) {
   MachineRegisterInfo &MRI = *B.getMRI();
----------------
Commented-out param?


================
Comment at: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp:1122
+
+  return (SrcTy.isPointer() && DstTy.isScalar()) ||
+         (DstTy.isScalar() && SrcTy.isPointer());
----------------
Why is `SrcTy.isPointer() == DstTy.isPointer()` not allowed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101234/new/

https://reviews.llvm.org/D101234