[PATCH] D100094: [ARM] Simplification to ARMBlockPlacement Pass.

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks for the tests. In the interest of fixing the bug that this fixes, LGTM.



================
Comment at: llvm/lib/Target/ARM/ARMBlockPlacement.cpp:130
+            << DEBUG_PREFIX
+            << "Can't move the Predecessor block as it would convert a WLS"
+               "from forward branching to a backwards branching WLS\n");
----------------
Can you format this line so it flows better.


================
Comment at: llvm/test/CodeGen/Thumb2/block-placement.mir:195
   bb.3:
-    successors: %bb.3(0x7c000000), %bb.1(0x04000000)
+    successors: %bb.3(0x7c000000), %bb.4(0x04000000)
     liveins: $lr, $r1, $r2
----------------
Should this be bb.1 and bb.4?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100094/new/

https://reviews.llvm.org/D100094