[PATCH] D98509: [LV] Calculate max feasible scalable VF.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 4 07:53:28 PDT 2021


fhahn added a comment.

In D98509#2732628 <https://reviews.llvm.org/D98509#2732628>, @hubert.reinterpretcast wrote:

> In D98509#2725892 <https://reviews.llvm.org/D98509#2725892>, @hubert.reinterpretcast wrote:
>
>> In D98509#2725672 <https://reviews.llvm.org/D98509#2725672>, @sdesmalen wrote:
>>
>>> Reverting the patch for a few days is fine, I've pushed rG51d648c119d7773ce6fb809353bd6bd14bca8818 <https://reviews.llvm.org/rG51d648c119d7773ce6fb809353bd6bd14bca8818> for now.
>>
>> Thank you! Our internal CI is green again. I'll update with the investigation progress once it gets to a meaningful point.
>
> I haven't reached the root cause yet, but it appears that the issue we're hitting can be avoided if the `MaxSafeVF` parameter is made pass-by-reference instead of pass-by-value.
> @sdesmalen, I hope the following is not too intrusive a change to your patch.

@hubert.reinterpretcast can you provide an IR test case that triggers the failure with sanitizers?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98509/new/

https://reviews.llvm.org/D98509



More information about the llvm-commits mailing list