[PATCH] D101639: Add build_fence to OCaml bindings

[Francesco Bertolaccini via Phabricator via llvm-commits]

frabert updated this revision to Diff 342713.
frabert added a comment.

Add tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101639/new/

https://reviews.llvm.org/D101639

Files:
  llvm/bindings/ocaml/llvm/llvm.ml
  llvm/bindings/ocaml/llvm/llvm.mli
  llvm/bindings/ocaml/llvm/llvm_ocaml.c
  llvm/test/Bindings/OCaml/core.ml


Index: llvm/test/Bindings/OCaml/core.ml
===================================================================
--- llvm/test/Bindings/OCaml/core.ml
+++ llvm/test/Bindings/OCaml/core.ml
@@ -1119,6 +1119,9 @@
      * CHECK: %build_shufflevector = shufflevector <4 x i32> %Vec1, <4 x i32> %Vec2, <4 x i32> <i32 1, i32 1, i32 0, i32 0>
      * CHECK: %build_insertvalue0 = insertvalue{{.*}}%bl, i32 1, 0
      * CHECK: %build_extractvalue = extractvalue{{.*}}%build_insertvalue1, 1
+     * CHECK: %build_fence0 = fence seq_cst
+     * CHECK: %build_fence1 = fence acquire
+     * CHECK: %build_fence2 = fence syncscope("singlethread") release
      *)
     let ci = build_call fn [| p2; p1 |] "build_call" atentry in
     insist (CallConv.c = instruction_call_conv ci);
@@ -1172,6 +1175,10 @@
     let agg1 = build_insertvalue agg0 (const_int i8_type 2) 1
                  "build_insertvalue1" atentry in
     ignore (build_extractvalue agg1 1 "build_extractvalue" atentry)
+
+    ignore (build_fence AtomicOrdering.SequentiallyConsistent false "build_fence0" atentry)
+    ignore (build_fence AtomicOrdering.Acquire false "build_fence1" atentry)
+    ignore (build_fence AtomicOrdering.Release true "build_fence2" atentry)
   end;
 
   group "metadata"; begin
Index: llvm/bindings/ocaml/llvm/llvm_ocaml.c
===================================================================
--- llvm/bindings/ocaml/llvm/llvm_ocaml.c
+++ llvm/bindings/ocaml/llvm/llvm_ocaml.c
@@ -2457,6 +2457,13 @@
   return LLVMBuildFreeze(Builder_val(B), X, String_val(Name));
 }
 
+/* AtomicOrdering.t -> bool -> string -> llbuilder -> llvalue */
+CAMLprim LLVMValueRef llvm_build_fence(value Ord, value ST, value Name,
+                                       value B) {
+  return LLVMBuildFence(Builder_val(B), Int_val(Ord), Bool_val(ST),
+                        String_val(Name));
+}
+
 /*===-- Memory buffers ----------------------------------------------------===*/
 
 /* string -> llmemorybuffer
Index: llvm/bindings/ocaml/llvm/llvm.mli
===================================================================
--- llvm/bindings/ocaml/llvm/llvm.mli
+++ llvm/bindings/ocaml/llvm/llvm.mli
@@ -2597,6 +2597,12 @@
     See the method [llvm::LLVMBuilder::CreateFreeze]. *)
 val build_freeze : llvalue -> string -> llbuilder -> llvalue
 
+(** [build_fence o st name b] creates a 
+    [%name = fence %o]
+    instruction with ordering [o] and singlethread flag set to [st] at the
+    position specified by the instruction builder [b].
+    See the method [llvm::LLVMBuilder::CreateFence]. *)
+val build_fence : AtomicOrdering.t -> bool -> string -> llbuilder -> llvalue
 
 (** {6 Memory buffers} *)
 
Index: llvm/bindings/ocaml/llvm/llvm.ml
===================================================================
--- llvm/bindings/ocaml/llvm/llvm.ml
+++ llvm/bindings/ocaml/llvm/llvm.ml
@@ -1348,6 +1348,8 @@
                             = "llvm_build_extractvalue"
 external build_insertvalue : llvalue -> llvalue -> int -> string -> llbuilder ->
                              llvalue = "llvm_build_insertvalue"
+external build_fence : AtomicOrdering.t -> bool -> string -> llbuilder ->
+                       llvalue = "llvm_build_fence"
 
 external build_is_null : llvalue -> string -> llbuilder -> llvalue
                        = "llvm_build_is_null"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101639.342713.patch
Type: text/x-patch
Size: 3312 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210504/0e9a6637/attachment.bin>