[llvm] 791930d - Re-reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands"

[via llvm-commits]

> Were these assertions firing on the existing test cases but on different architectures (if so, maybe it's worth adding versions of the test (or new RUN lines) that target those architectures so the failure's exercised on all buildbots with that target built?) - or were they only firing during something like a bootstrap? In which case maybe some more test coverage would be desirable to exercise these codepaths/conditions more directly?
I think adding more test cases here to cover that code path is probably appropriate; the asserts were specifically in the DWARF emission step of the pipeline, asserting that only non-constant arguments were used for DBG_VALUE_LISTs. This assertion is not strictly correct (it was used mainly for testing) but it didn't trigger at all on a number of large projects, so slipped by relatively unnoticed. The fact that emitting constant operands for DBG_VALUE_LIST is not covered by any kind of test is an issue that should be fixed, along with any other currently untested operand types.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210504/4a09838d/attachment.html>