[PATCH] D101822: [llvm-objdump] Use std::make_unique

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 4 02:12:31 PDT 2021


tpr created this revision.
Herald added a subscriber: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a reviewer: MaskRay.
tpr requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fix up my recent commit to use std::make_unique instead of
std::unique_ptr(new), as requested by David Blaikie.

Change-Id: Ic683d584b06d8d29ccd8179984a05024f8e84d2a


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101822

Files:
  llvm/tools/llvm-objdump/llvm-objdump.cpp


Index: llvm/tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -1015,7 +1015,7 @@
                     LabelAddrs.begin());
   // Add the labels.
   for (unsigned LabelNum = 0; LabelNum != LabelAddrs.size(); ++LabelNum) {
-    std::unique_ptr<std::string> Name(new std::string);
+    auto Name = std::make_unique<std::string>();
     *Name = (Twine("L") + Twine(LabelNum)).str();
     SynthesizedLabelNames.push_back(std::move(Name));
     Symbols.push_back(SymbolInfoTy(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101822.342678.patch
Type: text/x-patch
Size: 618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210504/1c5a822d/attachment.bin>


More information about the llvm-commits mailing list