[PATCH] D101697: [llvm-objcopy] --dump-section: error if '=' is missing or filename is empty

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Add a link to the PR.

LGTM otherwise.



================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:703
   }
-  for (auto Arg : InputArgs.filtered(OBJCOPY_dump_section))
-    Config.DumpSection.push_back(Arg->getValue());
+  for (auto Arg : InputArgs.filtered(OBJCOPY_dump_section)) {
+    StringRef Value(Arg->getValue());
----------------
Consider fixing clang-tidy warning whilst you're changing this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101697/new/

https://reviews.llvm.org/D101697