[PATCH] D101695: [llvm-objdump] Add -M {att,intel} as user-facing alternatives to --x86-asm-syntax={att,intel}

[James Henderson via Phabricator via llvm-commits]

jhenderson added a subscriber: gbreynoo.
jhenderson added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-objdump.rst:249
 
 .. option:: --x86-asm-syntax=<style>
 
----------------
If this option is to be deprecated, we should update this part of the docs one way or another. What's the motivation to remove it though? We have many other cases of keeping older option names around in the LLVM tools. I'm not opposed to it. Just trying to understand the thought process.

(For the record, I don't //think// we have any internal users of this option - I'll make sure this is looked at downstream)


================
Comment at: llvm/test/tools/llvm-objdump/X86/syntax-mode.s:1
+## Test att and intel syntax modes.
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t
----------------
Perhaps also worth the long-form version of the option (i.e. `--disassembler-options`)? With and without the `=`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101695/new/

https://reviews.llvm.org/D101695