[PATCH] D101736: [WebAssembly] Allow DBG_VALUE after terminator in MachineVerifier

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

In D101736#2733694 <https://reviews.llvm.org/D101736#2733694>, @aardappel wrote:

> Yes, this makes sense to me. Another way to put it is that our `br_if` has the side effect of forcing termination of a "register" lifetime, which is uncommon.
>
> Does LLVM not emit code for any other stack machines where this could happen? x87? :)

I don't know. I searched briefly but haven't figured out how debug info works in x87 yet. It might take some more time. I'd appreciate if you know any pointers.

> The check is sadly not particularly elegant. I wonder if maintainers of common code would like this code better if instead it was moved into the `else if` below, purely to suppress the error. Makes the common logic slightly easier to follow?

Yeah it is hacky, and I'm not sure how to avoid it. I thought about merging the condition in the `else` part, but ended up not doing it because it makes the code less readable, and I also thought separating the hacky part as its own block might help others to read the code. But if you think it doesn't help reading please let me know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101736/new/

https://reviews.llvm.org/D101736