[PATCH] D101363: [ASAN] NFC: Use addrspace cast for pointers in non-zero addrspace

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

Sorry, somehow I missed that the function is not just internal Asan utility. 
David, thanks for rising this up.

In D101363#2732772 <https://reviews.llvm.org/D101363#2732772>, @dblaikie wrote:

> In D101363#2732717 <https://reviews.llvm.org/D101363#2732717>, @rksharma wrote:
>
>> The change in this patch is implicitly tested by all the tests introduced in https://reviews.llvm.org/D99071
>> asan-module pass will append globals to the used list and for AMDGPU these globals will be in non-zero addrspaces.
>
> In the future - semantic changing patches should be part of commits that test them, not committed separately.
>
> If this change was separable, it should've included separate tests with it - such as an IR test with a global in the used list, by the sounds of it?



In D101363#2732772 <https://reviews.llvm.org/D101363#2732772>, @dblaikie wrote:

> In D101363#2732717 <https://reviews.llvm.org/D101363#2732717>, @rksharma wrote:
>
>> The change in this patch is implicitly tested by all the tests introduced in https://reviews.llvm.org/D99071
>> asan-module pass will append globals to the used list and for AMDGPU these globals will be in non-zero addrspaces.
>
> In the future - semantic changing patches should be part of commits that test them, not committed separately.
>
> If this change was separable, it should've included separate tests with it - such as an IR test with a global in the used list, by the sounds of it?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101363/new/

https://reviews.llvm.org/D101363