[PATCH] D101395: [lld-macho] Implement builtin section renaming

[Greg McGary via Phabricator via llvm-commits]

gkm marked 3 inline comments as done.
gkm added inline comments.


================
Comment at: lld/MachO/MergedOutputSection.cpp:26-27
   } else {
-    mergeFlags(input->flags);
     align = std::max(align, input->align);
+    mergeFlags(input);
   }
----------------
int3 wrote:
> intentional change?
Yes, though semi-gratuitous. I like seeing all the simple assignments from both sides if the `if (inputs.empty())` stacked together.


================
Comment at: lld/test/MachO/builtin-rename.s:5
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin \
+# RUN:     %t/main.s -o %t/main.o 2>/dev/null
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin \
----------------
int3 wrote:
> why the `2>/dev/null`?
Copy pasta.


================
Comment at: lld/test/MachO/builtin-rename.s:25-27
+# RUN:     Filecheck %s --check-prefixes=CHECK,NDATA
+# RUN: llvm-objdump --syms %t/nopie | \
+# RUN:     Filecheck %s --check-prefixes=CHECK,NDATA
----------------
int3 wrote:
> 
Ugh. Thanx. Case-insensitive filesystem names suck.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101395/new/

https://reviews.llvm.org/D101395