[PATCH] D101711: [lld][WebAssembly] Convert more tests to asm format

Mon May 3 17:08:04 PDT 2021

sbc100 added inline comments.

================
Comment at: lld/test/wasm/shared.s:109
+
+.section .custom_section.target_features,"",@
+.int8 1
----------------
dschuff wrote:
> sbc100 wrote:
> > dschuff wrote:
> > > Does this actually affect the link?
> > Yes.  Without this, one cannot import `__stack_pointer` since its mutable.  
> Ah, right. I guess if we really wanted asm to be a first-class citizen we'd want a directive such as `.target_features` so asm writers wouldn't have to encode this manually. Maybe in a future where basically all compilations use post-MVP features, it will be worth it, but probably not now.
Yes, I was thinking of adding a comment here that this is a little clunky.. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101711/new/

https://reviews.llvm.org/D101711