[PATCH] D101716: [lld][WebAssembly] Fix crash with `-pie` without `--allow-undefined`

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 3 15:48:15 PDT 2021


sbc100 added a comment.

In D101716#2734815 <https://reviews.llvm.org/D101716#2734815>, @dschuff wrote:

> So this change means that unresolved symbols will turn into imports when linking?

Yes, this was already the assumption of code that reported undefined symbols.    In emscripten this had gone unnoticed because we have traditionally also always passed `--allow-undefined`.

Our experimental `-pie` and `-shared` modes implicitly include `--allow-undefined` (at least for now they do).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101716/new/

https://reviews.llvm.org/D101716



More information about the llvm-commits mailing list