[PATCH] D100884: Generalize getInvertibleOperand recurrence handling slightly

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 3 15:27:07 PDT 2021


reames added a comment.

It turns out the issue which triggered the revert was latent in the previous code as well.  Sanjay fixed that in 15a4233 <https://reviews.llvm.org/rG15a42339fe5f5daa86651e181df9a4f89d3ededf>.  The root issue was that with the current definition of recurrence we can have two recurrence phis which share an increment.  I had not realized this, and thus the overly strong asserts.

Now that the reduced test case has been submitted, I'm going to tweak this one and resubmit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100884/new/

https://reviews.llvm.org/D100884



More information about the llvm-commits mailing list