[PATCH] D101578: [Attributor][WIP] Add AAExecutionDomainInfo interface
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 3 13:27:59 PDT 2021
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, two minor nits.
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2298
+ LLVM_DEBUG({
+ for (const auto &E : SingleThreadedBBs)
+ dbgs() << TAG << " Basic block @" << getAnchorScope()->getName() << " "
----------------
Here and elsewhere, if the type is trivial, use it. 4 vs 9 chars but better readability.
E is not a good variable name for a BB.
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2339-2341
+ AllCallSitesKnown)) {
+ SingleThreadedBBs.erase(&F->getEntryBlock());
+ }
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101578/new/
https://reviews.llvm.org/D101578
More information about the llvm-commits
mailing list