[PATCH] D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 3 13:04:06 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/lib/MC/ELFObjectWriter.cpp:1385
+
+      // Work around an issue in MIPS relocation handling: both R_MIPS_HI16 and
+      // R_MIPS_LO16 are considered as absolute relocations (the ld.lld type is
----------------
Simplify as my main comment suggests, with potentially less wording.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101773/new/

https://reviews.llvm.org/D101773



More information about the llvm-commits mailing list