[PATCH] D101761: [llvm-objdump] support "-M att" and "-M intel" flags

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 3 12:28:27 PDT 2021


MaskRay added a comment.

In D101761#2734213 <https://reviews.llvm.org/D101761#2734213>, @thakis wrote:

> In D101761#2733927 <https://reviews.llvm.org/D101761#2733927>, @MaskRay wrote:
>
>> In D101761#2733856 <https://reviews.llvm.org/D101761#2733856>, @thakis wrote:
>>
>>> In D101761#2733553 <https://reviews.llvm.org/D101761#2733553>, @MaskRay wrote:
>>>
>>>> D101695 <https://reviews.llvm.org/D101695>
>>>
>>> Oh, cool. Your patch doesn't get interleaving both kinds of options right though afaict.
>>
>> I don't think that is necessary. Users shouldn't use `--x86-asm-syntax`. Actually we probably should remove it afterwards.
>
> Works for me!
>
> But since that's the only way to get this atm, it's mentioned in a bunch of places: https://stackoverflow.com/questions/10362630/how-can-objdump-emit-intel-syntax#comment97536406_10362655
>
> So maybe support both for a release or so?

Deleting `--x86-asm-syntax` before 14.0.0 branches LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101761/new/

https://reviews.llvm.org/D101761



More information about the llvm-commits mailing list