[PATCH] D101594: DAG: Cleanup assertion in EmitFuncArgumentDbgValue

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 3 11:57:59 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/ptr-arg-dbg-value.ll:4
+%struct.A = type { [100 x i32] }
+
+define hidden void @ptr_arg_dbg_value(%struct.A* %arg) #0 !dbg !9 {
----------------
Add a comment explaining what this tests


================
Comment at: llvm/test/CodeGen/AMDGPU/ptr-arg-dbg-value.ll:14
+}
+
+declare void @llvm.dbg.declare(metadata, metadata, metadata) #0
----------------
Maybe also add a case where the pointer ends up passed in memory, and another where half is in memory and half in a register


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101594/new/

https://reviews.llvm.org/D101594



More information about the llvm-commits mailing list