[PATCH] D101720: [InstCombine] generalize select + select/and/or folding using implied conditions

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:2573
+    auto *SI0 = dyn_cast<SelectInst>(Op0), *SI1 = dyn_cast<SelectInst>(Op1);
+    if (SI0) {
+      if (auto *I =
----------------
`if (auto *SI0 = dyn_cast<SelectInst>(Op0))` would be more idiomatic, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101720/new/

https://reviews.llvm.org/D101720