[llvm] 1d29925 - [DebuggerTuning] Move a comment to a more useful place.

[Paul Robinson via llvm-commits]

Author: Paul Robinson
Date: 2021-05-03T11:08:04-07:00
New Revision: 1d299252dd52ade0e87485be29443aa69be9e910

URL: https://github.com/llvm/llvm-project/commit/1d299252dd52ade0e87485be29443aa69be9e910
DIFF: https://github.com/llvm/llvm-project/commit/1d299252dd52ade0e87485be29443aa69be9e910.diff

LOG: [DebuggerTuning] Move a comment to a more useful place.

The comment about how to make use of debugger tuning within DwarfDebug
really belongs inside the DwarfDebug declaration, where it will be
easier to find.

Added: 
    

Modified: 
    llvm/include/llvm/Target/TargetOptions.h
    llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Target/TargetOptions.h b/llvm/include/llvm/Target/TargetOptions.h
index 5dab7de949066..cad356edacec1 100644
--- a/llvm/include/llvm/Target/TargetOptions.h
+++ b/llvm/include/llvm/Target/TargetOptions.h
@@ -100,10 +100,6 @@ namespace llvm {
   /// o if the feature is useful (or not) on a particular platform, regardless
   ///   of the debugger, that's a target decision.
   /// It's not impossible to see both factors in some specific case.
-  ///
-  /// The "tuning" should be used to set defaults for individual feature flags
-  /// in DwarfDebug; if a given feature has a more specific command-line option,
-  /// that option should take precedence over the tuning.
   enum class DebuggerKind {
     Default, ///< No specific tuning requested.
     GDB,     ///< Tune debug info for gdb.

diff  --git a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
index 77e4f20a28884..6356a65b50d38 100644
--- a/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
@@ -440,7 +440,11 @@ class DwarfDebug : public DebugHandlerBase {
   AccelTable<AppleAccelTableOffsetData> AccelNamespace;
   AccelTable<AppleAccelTableTypeData> AccelTypes;
 
-  // Identify a debugger for "tuning" the debug info.
+  /// Identify a debugger for "tuning" the debug info.
+  ///
+  /// The "tuning" should be used to set defaults for individual feature flags
+  /// in DwarfDebug; if a given feature has a more specific command-line option,
+  /// that option should take precedence over the tuning.
   DebuggerKind DebuggerTuning = DebuggerKind::Default;
 
   MCDwarfDwoLineTable *getDwoLineTable(const DwarfCompileUnit &);