[PATCH] D78203: [VP,Integer,#2] ExpandVectorPredication pass

Mon May 3 10:54:01 PDT 2021

aprantl added a comment.

In D78203#2732842 <https://reviews.llvm.org/D78203#2732842>, @simoll wrote:

> In D78203#2730888 <https://reviews.llvm.org/D78203#2730888>, @aprantl wrote:
>
>> Since it's already late on Friday I took the liberty to revert the commit so the bots can recover and you can investigate the failure at your own pace. Let me know if I can help with the fix!
>
> Thanks for taking action! I'll look into how `include/llvm/CodeGen/MachinePassRegistry.def` actually works.. i suppose moving the entry from `DUMMY_FUNCTION_PASS` to `FUNCTION_PASS` should fix this (will reproduce and fix locally). Never had a revert, what is the usual procedure to recommit after revert? (update/new diff, review, or just commit with the fix?)

You can just re-commit with a comment in the commit message explaining how the re-commit differs from the original one. Unless you make substantial changes or you are unsure about your solution, there is no need to re-review the patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78203/new/

https://reviews.llvm.org/D78203