[PATCH] D101736: [WebAssembly] Allow DBG_VALUE after terminator in MachineVerifier

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added a comment.

Yes, this makes sense to me. Another way to put it is that our `br_if` has the side effect of forcing termination of a "register" lifetime, which is uncommon.

Does LLVM not emit code for any other stack machines where this could happen? x87? :)

The check is sadly not particularly elegant. I wonder if maintainers of common code would like this code better if instead it was moved into the `else if` below, purely to suppress the error. Makes the common logic slightly easier to follow?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101736/new/

https://reviews.llvm.org/D101736