[PATCH] D97667: [loop-idiom] Hoist loop memcpys to loop preheader

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 3 07:57:23 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:869
+
+  if (SizeInBytes != StoreStrideValue && SizeInBytes != -StoreStrideValue) {
+    ORE.emit([&]() {
----------------
I suspect we will still see crashes here.
Since you use `getSExtValue()` later, just move that to before this, and compare ints?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97667/new/

https://reviews.llvm.org/D97667



More information about the llvm-commits mailing list