[PATCH] D101145: [MC][AMDGPU][llvm-objdump] Synthesized local labels in disassembly

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1010-1012
+  std::vector<uint64_t> LabelAddrs;
+  LabelAddrs.insert(LabelAddrs.end(), LabelAddrsRef.begin(),
+                    LabelAddrsRef.end());
----------------
Can't you populate this on construction? `std::vector<uint64_t> LabelAddrs(LabelAddrsRef.begin(), LabelAddrsRef.end());`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101145/new/

https://reviews.llvm.org/D101145