[PATCH] D101304: AMDGPU/llvm-readobj: Add missing tests for note parsing/displaying

[Albion Fung via Phabricator via llvm-commits]

Conanap added a comment.

Hello,

  The `reland` version of this patch for which I cannot find the differential of has broken for `LLVM::note-amd-valid-v2.test` on PowerPC:

  /home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test:17:14: error: LLVM-NEXT: expected string not found in input
  # LLVM-NEXT: AMD HSA Code Object Version: [Major: 2, Minor: 1]
               ^
  <stdin>:15:68: note: scanning from here
   Type: NT_AMD_HSA_CODE_OBJECT_VERSION (AMD HSA Code Object Version)
                                                                     ^
  <stdin>:16:2: note: possible intended match here
   AMD HSA Code Object Version: [Major: 33554432, Minor: 16777216]
   ^
  Input file: <stdin>
  Check file: /home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.test
  -dump-input=help explains the following input dump.
  Input was:
  <<<<<<
             .
             .
             .
            10:  Offset: 0x40 
            11:  Size: 0x18 
            12:  Note { 
            13:  Owner: AMD 
            14:  Data size: 0x8 
            15:  Type: NT_AMD_HSA_CODE_OBJECT_VERSION (AMD HSA Code Object Version) 
  next:17'0                                                                        X error: no match found
            16:  AMD HSA Code Object Version: [Major: 33554432, Minor: 16777216] 
  next:17'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  next:17'1      ?                                                                possible intended match

Seems like a small fix but if you could have a push for it soon that'd be great. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101304/new/

https://reviews.llvm.org/D101304