[PATCH] D101724: [lld-macho] De-templatize mach_header operations

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 3 05:52:05 PDT 2021


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Nice, thanks!



================
Comment at: lld/MachO/SyntheticSections.cpp:130
     }
   }
 
----------------
We should probably `memset(buf + sizeof(mac_header), target->headerSize - sizeof(mac_header), 0)` here to make sure that the `reserved` field is set to some deterministic data here. (Or is the output pre-zeroed? Probably not?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101724/new/

https://reviews.llvm.org/D101724



More information about the llvm-commits mailing list