[PATCH] D101626: [TableGen] Fix two bugs in 'defm' when a complex 'assert' is involved

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/test/TableGen/assert.td:197
+// CHECK: note: MC5 name must include a space: Ada_Lovelace
+// CHECK: assertion failed
+// CHECK: note: person age is invalid: 666
----------------
jansvoboda11 wrote:
> Paul-C-Anagnostopoulos wrote:
> > jansvoboda11 wrote:
> > > I'd expect TableGen to report only the first assertion failure and abort immediately. What's the logic behind the current behavior?
> > Assertion failures are not fatal, so that other errors in the .td files can be reported at the same time.
> What if the assertion failure is the only error in the .td file? Will TableGen exit with a non-zero code?
Yes. Both errors and fatal errors increment the error count, which is used to determine the exit code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101626/new/

https://reviews.llvm.org/D101626