[PATCH] D101748: Add inclusion filename filters to llvm-cov

Lukas Barth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 3 03:36:38 PDT 2021


tinloaf added a comment.

I tested this locally and it seems to work; however, I would feel better if I had some tests for this (and the ignore-regex filters, too).

As far as I can tell, there would be two steps to adding tests to this:

- Add a test script at (e.g.) `llvm/test/tools/llvm-cov/filename_filters.test`
- Add some input data for this test script in the form of a "proftext" file at (e.g.) `llvm/test/tools/llvm-cov/Inputs/filename_filters.proftext`

However, I know neither the syntax of the `.test` scripts nor the syntax of the `proftext` format. If I generate some "proftext" file by running `llvm-profdata -text …`, I can see the file names in the resulting output file, but no paths.  Searching for "proftext llvm" or "proftext format" does give me lots of other tests using this format, but no docs on the format itsef. If somebody could point me in the right direction, I'll gladly add some tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101748/new/

https://reviews.llvm.org/D101748



More information about the llvm-commits mailing list