[PATCH] D100257: [VPlan] Add VPUserID to distinguish between recipes and others.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal added a comment.

In D100257#2733025 <https://reviews.llvm.org/D100257#2733025>, @gilr wrote:

> The anticipated long-term need for non-recipe VPUsers is indeed to represent live-outs, along with their underlying IR Value, or rather Instruction; analogous to VPValue::getLiveInIRValue(). This would call for a derived VPLiveOut non-recipe subclass of VPUser.
>
> VPUser class itself should probably be pure virtual, similar to `User`, to avoid having a potential kitchen sink of dangling opaque instances. Instead of representing arbitrary "other"/"non-recipe" instances, the current VPUsers of VPBasicBlock predicates and conditions could be represented as specific, concrete subclasses of VPUser, potentially until they are cleaned up. WDYT?

+1



================
Comment at: llvm/lib/Transforms/Vectorize/VPlanValue.h:191
 
 /// This class augments VPValue with operands which provide the inverse def-use
 /// edges from VPValue's users to their defs.
----------------
nit: above comment needs updating.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100257/new/

https://reviews.llvm.org/D100257