[PATCH] D93534: [VP] Improve the VP intrinsic unittests

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

Everything else here looks good to me (though I'm not officially a reviewer so take that with some amount of salt)



================
Comment at: llvm/unittests/IR/VPIntrinsicTest.cpp:213
+    // no equivalent Opcode available
+    if (OC == Instruction::Call)
+      continue;
----------------
I know this wasn't introduced by this patch, but why `Call` and not something like `Optional<unsigned> None`? I just had to go and look up how `GetFunctionalOpcodeForVP` is implemented to see if this is a special case. It's also not documented by the comments above that method's declaration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93534/new/

https://reviews.llvm.org/D93534