[PATCH] D78778: [AsmPrinter] Fix emitting CFI for debug when exceptions are not supported

Fri Apr 30 11:33:57 PDT 2021

aheejin added subscribers: aardappel, yurydelendik.
aheejin added a comment.

In D78778#2727655 <https://reviews.llvm.org/D78778#2727655>, @RamNalamothu wrote:

> In D78778#2720397 <https://reviews.llvm.org/D78778#2720397>, @dblaikie wrote:
>
>> In D78778#2719704 <https://reviews.llvm.org/D78778#2719704>, @RamNalamothu wrote:
>>
>>> Fix couple of WebAsembly debug info LIT tests, as we now emit .debug_frame when no exceptions.
>>
>> Hmm - was this intended to change the behavior of WebAssembly? Could you get someone with some WebAssembly context to double check this is desirable behavior?
>
> Not intended but probably the LIT test updates are expected for WebAssembly. Adding @aheejin as well to review those.
> Please note that those LIT tests are not explicitly checking for either presence/non-presense of `.eh_frame` or `.debug_frame` and might have just tried to match the compiler output back then.
>
> However, while I still feel the current `usesCFIForDebug()` approach is in the right direction, please let me know if the preferred approach is a target configurable option and if yes, I can update this review with https://reviews.llvm.org/D101592 changes (not meant to be reviewed there).

I am not very familiar with these tests. Perhaps any of @aardappel @sbc100 @yurydelendik would know.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78778/new/

https://reviews.llvm.org/D78778