[PATCH] D56923: [AMDGPU] Fixed hazard recognizer to walk predecessors

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.
Herald added a subscriber: kerbowa.
Herald added a project: LLVM.


================
Comment at: llvm/trunk/lib/Target/AMDGPU/GCNHazardRecognizer.cpp:317
+    if (IsExpired(nullptr, MinWaitStates))
+      return MinWaitStates;
+
----------------
I think this early return is broken, because there might be another predecessor that has a smaller value of MinWaitStates which would not satisfy the IsExpired test. Do you agree? (Sorry for reopening such an old review.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56923/new/

https://reviews.llvm.org/D56923