[PATCH] D101363: [ASAN] NFC: Use addrspace cast for pointers in non-zero addrspace
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 2 22:31:46 PDT 2021
dblaikie added a comment.
In D101363#2732717 <https://reviews.llvm.org/D101363#2732717>, @rksharma wrote:
> The change in this patch is implicitly tested by all the tests introduced in https://reviews.llvm.org/D99071
> asan-module pass will append globals to the used list and for AMDGPU these globals will be in non-zero addrspaces.
In the future - semantic changing patches should be part of commits that test them, not committed separately.
If this change was separable, it should've included separate tests with it - such as an IR test with a global in the used list, by the sounds of it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101363/new/
https://reviews.llvm.org/D101363
More information about the llvm-commits
mailing list