[PATCH] D101725: [Verifier] Check that calls' arguments match the callee's byval/inalloca/preallocated

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 2 17:30:19 PDT 2021


aeubanks added a comment.

I think the bitcode and textual representation both allow this issue.
But based on the fact that so much of the checking for byval and related attributes is on the arguments rather than the parameters, IMO it's always been intended to have the attributes at least on the parameters. Users like Clang have always been properly emitting byval on the parameters (no check-clang tests regressed). This patch is just filling in a hole that should always have been filled in. But maybe someone else should chime in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101725/new/

https://reviews.llvm.org/D101725



More information about the llvm-commits mailing list