[PATCH] D101732: [M68k][AsmParser] Support negative integer constants
Ricky Taylor via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 2 15:19:34 PDT 2021
ricky26 added a comment.
Somehow my comment got trimmed (I think because a new diff appeared between me writing it and pressing submit).
================
Comment at: llvm/lib/Target/M68k/AsmParser/M68kAsmParser.cpp:590
+ case AsmToken::Minus:
+ return getLexer().peekTok().getKind() == AsmToken::Integer;
----------------
nit: Is this totally necessary? I don't think `-` can appear at the start of anything else apart from possibly an identifier (which is parsed by `parseExpression` anyway).
This doesn't make much difference though (but could preserve const).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101732/new/
https://reviews.llvm.org/D101732
More information about the llvm-commits
mailing list