[PATCH] D101410: [M68k][test] Initial migration of MC tests

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

You should probably model your relocation tests on the RISC-V ones, those are a lot cleaner in style



================
Comment at: llvm/test/MC/M68k/Relocations/text-plt.s:5
+	.text
+	.globl	TEXT                            ; -- Begin function TEXT
+	.type	TEXT, at function
----------------
Why are there auto-generated comments? You don't need `.text`. Why is the symbol all-caps, that's not idiomatic?


================
Comment at: llvm/test/MC/M68k/Relocations/text-plt.s:7
+	.type	TEXT, at function
+#        Offset    Info           Type            Sym. Value  Sym     S  Addend
+# CHECK: 00000002  {{[0-9a-f]+}}  R_68K_PLT16  {{[0-9]*}}  TARGET  +  0
----------------
Don't mix comment styles, pick one and stick with it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101410/new/

https://reviews.llvm.org/D101410