[PATCH] D101725: [Verifier] Check that calls' arguments match the callee's byval/inalloca/preallocated
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 2 13:22:53 PDT 2021
dblaikie added a comment.
Though does this break bitcode backwards compatibility, or does the bitcode not have this ambiguity/duplication?
While the textual IR doesn't have backcompat issues - maybe it'd be easy enough for the textual IR parser to correct this issue by checking the declaration and attaching the right attribute value? Though not necessary by any means.
================
Comment at: llvm/lib/IR/Verifier.cpp:3274-3277
Assert(!FTy->getReturnType()->isTokenTy(),
- "Return type cannot be token for indirect call!");
+ "Return type cannot be token for indirect call!", Call);
Assert(!FTy->getReturnType()->isX86_AMXTy(),
+ "Return type cannot be x86_amx for indirect call!", Call);
----------------
Should this be in a separate patch? (looks not strictly related/required in this patch)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101725/new/
https://reviews.llvm.org/D101725
More information about the llvm-commits
mailing list