[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

> Assembly tests are generally discouraged in clang, but in this case we actually care about the specific instruction being generated from the intrinsics.

I don't think this is a sound reason to add an end-to-end test in clang. The same is true of all clang tests, right? We ultimately care that accessing a parameter lowers to a certain register (because we're trying to implement a certain ABI) but we don't test that in clang - we test that we lower to certain IR which is guaranteed to lower to a certain register use - and then in LLVM we test that that IR does lower to that register.

I think the same holds true here - and a clang test should verify the IR and an LLVM test should verify the assembly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101684/new/

https://reviews.llvm.org/D101684