[PATCH] D101402: [lld-macho] Don't put an antivirus test file in reproduce.s

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 2 13:08:37 PDT 2021


dblaikie added inline comments.


================
Comment at: lld/test/MachO/reproduce.s:8
 # RUN: echo '_main' > %t.dir/main.order
-# RUN: echo 'X5O!P%@AP[4\PZX54(P^)7CC)7}$EICAR-STANDARD-ANTIVIRUS-TEST-FILE!$H+H*' > %t.dir/sectdata.txt
+# RUN: echo 'not a virus' > %t.dir/sectdata.txt
 # RUN: cd %t.dir
----------------
Maybe just "this is a test" or something would be more clear/not raise some weird suspicion when someone goes back to maintain this test about why viruses (or lack thereof) would be relevant to this test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101402/new/

https://reviews.llvm.org/D101402



More information about the llvm-commits mailing list