[PATCH] D101444: [demangler] Initial support for the new Rust mangling scheme

Sun May 2 12:13:00 PDT 2021

tmiasko marked 2 inline comments as done.
tmiasko added a comment.

In D101444#2732206 <https://reviews.llvm.org/D101444#2732206>, @tschuett wrote:

> Stupid question! Why does the rust demangler has to follow the API of
>
>   __cxa_demangle
>
> instead of a modern API with `llvm::Error`   and a `BumpPtrAllocator` ? Or SmallString and StringRef.

It is hard to realize the benefits of an improved API when it is inconsistent with API offered by other demanglers (earlier comments regarding API can be found in https://reviews.llvm.org/D101444?id=341152#inline-959049).

I don't have commit access. Could you commit this for me?  Thank you.

`Tomasz Miąsko <tomasz.miasko at gmail.com>`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101444/new/

https://reviews.llvm.org/D101444