[PATCH] D98941: [cmake] Enable Clang warnings about redundant semicolons

Sun May 2 11:53:46 PDT 2021

mstorsjo added a comment.

In D98941#2730846 <https://reviews.llvm.org/D98941#2730846>, @nickdesaulniers wrote:

> I think one of the buildbots is failing with this IIUC?
> https://lab.llvm.org/buildbot/#/builders/4/builds/8255
> /b/1/openmp-gcc-x86_64-linux-debian/llvm.src/openmp/runtime/src/kmp_i18n.h:173:2: warning: extra ';' outside of a function is incompatible with C++98 [-Wc++98-compat-extra-semi]
>
> Looks like a straightforward fix, though that code hasn't changed recently, and this change went in over a month ago.

It doesn't seem like it's failing over that to me? But it does indeed seem to spam a number of warnings in that setup. I pushed a commit to get rid of those redundant semicolons at least, in rG01d27fc40836 <https://reviews.llvm.org/rG01d27fc408367200f00daad2c2d0918b252acd2c> - thanks for noticing!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98941/new/

https://reviews.llvm.org/D98941