[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added a comment.

>> Perhaps that should warn even if the RHS is in hex form

It would be kinda strange, since in one clang release we ask users to silence warning with hex form and newer release would warn anyway. Not a fan of this decision.

>> , or is an enumerator constant, or

This looks like a good idea. +1.

>> is not even constant at all.

Depends, needs to be carefully evaluated (true positives vs false positives ratio).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63423/new/

https://reviews.llvm.org/D63423