[PATCH] D101375: [InstCombine] Add a few more patterns for folding select of select

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 1 20:25:50 PDT 2021


aqjune marked 2 inline comments as done.
aqjune added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/select-safe-transforms.ll:156
   %x_inv = icmp sle i37 %a, %b
   %y = icmp ugt i37 %c, 42      ; thwart complexity-based ordering
   %or = select i1 %y, i1 true, i1 %x
----------------
spatel wrote:
> How is this test different than the one above it?
> Is the comment about complexity-based ordering copy/pasted here? I'm not seeing why it is necessary in these tests (could we just pass in an i1 argument to the function?).
Yes, it was redundant, I fixed it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101375/new/

https://reviews.llvm.org/D101375



More information about the llvm-commits mailing list