[PATCH] D101689: [X32][CET] Fix size and alignment of .note.gnu.property section

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 1 14:11:31 PDT 2021


hvdijk marked an inline comment as done.
hvdijk added inline comments.


================
Comment at: llvm/test/CodeGen/X86/note-cet-property.ll:3
 ; RUN: llc -mtriple x86_64-pc-linux < %s | FileCheck %s --check-prefix=X86_64
+; RUN: llc -mtriple x86_64-pc-linux-gnux32 < %s | FileCheck %s --check-prefix=X86
 
----------------
MaskRay wrote:
> you can omit `<`
llc writes to stdout by default when reading from stdin, and writes to <file>.s otherwise, so just dropping `<` doesn't work. It's possible to use `-o -` instead to explicitly specify writing to stdout but the other lines in this file and the other three CET test files all use `llc < %s` rather than `llc %s -o -`, so for consistency I'd rather leave it if that's okay too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101689/new/

https://reviews.llvm.org/D101689



More information about the llvm-commits mailing list