[PATCH] D101583: Partial revert of "Use std::foo_t rather than std::foo in LLVM." in googlebench

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 1 14:04:41 PDT 2021


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D101583#2727593 <https://reviews.llvm.org/D101583#2727593>, @jroelofs wrote:

> In D101583#2727555 <https://reviews.llvm.org/D101583#2727555>, @MaskRay wrote:
>
>> llvm/CMakeLists.txt sets `CMAKE_CXX_STANDARD` to 14.
>
> As "prior art", https://reviews.llvm.org/D93794 also backed out a c++14 feature from this component.
>
> Seems prudent to keep our diff with upstream googlebench as small as possible to make it easier to update in the future.

OK, did not know this is a local difference. If that is the case, LG.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101583/new/

https://reviews.llvm.org/D101583



More information about the llvm-commits mailing list